forkchoice: don't modify attestation during block production#86
Merged
unnawut merged 1 commit intoleanEthereum:mainfrom Oct 28, 2025
Merged
forkchoice: don't modify attestation during block production#86unnawut merged 1 commit intoleanEthereum:mainfrom
unnawut merged 1 commit intoleanEthereum:mainfrom
Conversation
Collaborator
|
@tcoratger There's a few more checks and smaller details that needs updating. Can we drop this PR and I'll submit a new one in a few hours? Sorry for the trouble 🙇 |
unnawut
approved these changes
Oct 28, 2025
Collaborator
unnawut
left a comment
unnawut
left a comment
There was a problem hiding this comment.
Actually nevermind. Thanks for swift PR as usual!
g11tech
reviewed
Oct 28, 2025
Contributor
g11tech
left a comment
g11tech
left a comment
There was a problem hiding this comment.
post merge review- all good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
🔗 Related Issues or PRs
Should close #82
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox -e all-checks,pytest